ivanzlenko commented on code in PR #6549:
URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2321227405


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java:
##########
@@ -148,7 +149,15 @@ public CompletableFuture<Void> startJoinCluster(ClusterTag 
clusterTag, NodeAttri
         return raftService.run(command, RaftCommandRunner.NO_TIMEOUT)
                 .thenAccept(response -> {
                     if (response instanceof ValidationErrorResponse) {
-                        throw new 
JoinDeniedException(((ValidationErrorResponse) response).reason());
+                        var validationErrorResponse = 
(ValidationErrorResponse) response;
+                        if (validationErrorResponse.isUserError()) {
+                            var invalidUserInputException = new 
InvalidUserInputException(validationErrorResponse.reason());
+
+                            throw new 
JoinDeniedException(invalidUserInputException.code(),  
invalidUserInputException);
+

Review Comment:
   ```suggestion
   ```



##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java:
##########
@@ -148,7 +149,15 @@ public CompletableFuture<Void> startJoinCluster(ClusterTag 
clusterTag, NodeAttri
         return raftService.run(command, RaftCommandRunner.NO_TIMEOUT)
                 .thenAccept(response -> {
                     if (response instanceof ValidationErrorResponse) {
-                        throw new 
JoinDeniedException(((ValidationErrorResponse) response).reason());
+                        var validationErrorResponse = 
(ValidationErrorResponse) response;

Review Comment:
   ```suggestion
                           var validationErrorResponse = 
(ValidationErrorResponse) response;
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to