adityamukho commented on code in PR #6549:
URL: https://github.com/apache/ignite-3/pull/6549#discussion_r2348163330
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/CmgRaftService.java:
##########
@@ -148,10 +149,18 @@ public CompletableFuture<Void>
startJoinCluster(ClusterTag clusterTag, NodeAttri
return raftService.run(command, RaftCommandRunner.NO_TIMEOUT)
.thenAccept(response -> {
if (response instanceof ValidationErrorResponse) {
- throw new
JoinDeniedException(((ValidationErrorResponse) response).reason());
+ var validationErrorResponse =
(ValidationErrorResponse) response;
+
+ if (validationErrorResponse.isInvalidNodeConfig()) {
+ var invalidNodeConfigurationException = new
InvalidNodeConfigurationException(validationErrorResponse.reason());
+
+ throw new
JoinDeniedException(invalidNodeConfigurationException.code(),
invalidNodeConfigurationException);
Review Comment:
If this involves adding a new error code in `ErrorGroups.java`, then I would
prefer to do that in a separate ticket, since it needs to be replicated in the
platform code as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
