AMashenkov commented on code in PR #7249:
URL: https://github.com/apache/ignite-3/pull/7249#discussion_r2630656378
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/RexUtils.java:
##########
@@ -1473,6 +1473,12 @@ public static boolean isLosslessCast(RexNode node) {
return source.getPrecision() <= target.getPrecision();
}
- return RexUtil.isLosslessCast(source, target);
+ if (source.getSqlTypeName() == SqlTypeName.REAL &&
target.getSqlTypeName() == SqlTypeName.FLOAT) {
Review Comment:
The difference between FLOAT and REAL is that the first one supports binary
precision `FLOAT(x)`, the second has some implementation-defined precision.
Do we support precision for float different from maximum?
If no, then we can say these types are equivalent and lossless cast is
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
