korlov42 commented on code in PR #7249:
URL: https://github.com/apache/ignite-3/pull/7249#discussion_r2629844542


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/CorrelatedSubqueryPlannerTest.java:
##########
@@ -196,15 +196,13 @@ public void testCorrelatesCollisionsMixed() throws 
Exception {
 
             List<LogicalCorrelate> correlates = findNodes(rel, 
byClass(LogicalCorrelate.class));
 
-            assertEquals(4, correlates.size());
+            assertEquals(2, correlates.size());
 
             // There are collisions by correlation id.
             assertEquals(correlates.get(0).getCorrelationId(), 
correlates.get(1).getCorrelationId());
-            assertEquals(correlates.get(0).getCorrelationId(), 
correlates.get(2).getCorrelationId());
-            assertEquals(correlates.get(0).getCorrelationId(), 
correlates.get(3).getCorrelationId());
 
+            // Cannot decorrelate further
             rel = planner.replaceCorrelatesCollisions(rel);

Review Comment:
   looks like `planner.replaceCorrelatesCollisions(rel);` is not needed 
anymore. Please file a jira to take a look later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to