Vladsz83 commented on code in PR #12605:
URL: https://github.com/apache/ignite/pull/12605#discussion_r2645867694
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAuthFailedMessage.java:
##########
@@ -48,40 +54,38 @@ public class TcpDiscoveryAuthFailedMessage extends
TcpDiscoveryAbstractMessage {
public TcpDiscoveryAuthFailedMessage(UUID creatorNodeId, InetAddress addr,
UUID targetNodeId) {
super(creatorNodeId);
- this.addr = addr;
+ this.addr = new InetAddressMessage(addr);
this.targetNodeId = targetNodeId;
}
- /**
- * @return Node for which authentication was failed.
- */
- public UUID getTargetNodeId() {
+ /** @return Node for which authentication was failed. */
+ public UUID targetNodeId() {
return targetNodeId;
}
- /**
- * @return Coordinator address.
- */
- public InetAddress address() {
- return addr;
+ /** @param targetNodeId Node for which authentication was failed. */
+ public void targetNodeId(UUID targetNodeId) {
+ this.targetNodeId = targetNodeId;
}
- /**
- * Serialize this message.
- */
- private void writeObject(ObjectOutputStream out) throws IOException {
- out.defaultWriteObject();
+ /** @return Coordinator address. */
Review Comment:
`Coordinator address message`
##########
modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAuthFailedMessage.java:
##########
@@ -48,40 +54,38 @@ public class TcpDiscoveryAuthFailedMessage extends
TcpDiscoveryAbstractMessage {
public TcpDiscoveryAuthFailedMessage(UUID creatorNodeId, InetAddress addr,
UUID targetNodeId) {
super(creatorNodeId);
- this.addr = addr;
+ this.addr = new InetAddressMessage(addr);
this.targetNodeId = targetNodeId;
}
- /**
- * @return Node for which authentication was failed.
- */
- public UUID getTargetNodeId() {
+ /** @return Node for which authentication was failed. */
+ public UUID targetNodeId() {
return targetNodeId;
}
- /**
- * @return Coordinator address.
- */
- public InetAddress address() {
- return addr;
+ /** @param targetNodeId Node for which authentication was failed. */
+ public void targetNodeId(UUID targetNodeId) {
+ this.targetNodeId = targetNodeId;
}
- /**
- * Serialize this message.
- */
- private void writeObject(ObjectOutputStream out) throws IOException {
- out.defaultWriteObject();
+ /** @return Coordinator address. */
+ public InetAddressMessage addressMessage() {
+ return addr;
+ }
- U.writeByteArray(out, addr.getAddress());
+ /** @param addr Coordinator address. */
Review Comment:
`Coordinator address message.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
