Vladsz83 commented on code in PR #12605:
URL: https://github.com/apache/ignite/pull/12605#discussion_r2645885202
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/DiscoveryMessageFactory.java:
##########
@@ -48,7 +52,8 @@
public class DiscoveryMessageFactory implements MessageFactoryProvider {
/** {@inheritDoc} */
@Override public void registerAll(MessageFactory factory) {
- factory.register((short)-100, InetAddressMessage::new, new
InetAddressMessageSerializer());
+ factory.register((short)-101, InetAddressMessage::new, new
InetAddressMessageSerializer());
Review Comment:
`InetSocketAddressMessage` extends `InetAddressMessage`. Its number should
be higher. We use negative numbering here, so -101 id bigger that -100 as
order. I sugget setting direct type -100 for `InetAddressMessage` and -101 for
`InetSocketAddressMessage`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
