xtern commented on code in PR #7400:
URL: https://github.com/apache/ignite-3/pull/7400#discussion_r2694707092
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/api/AsyncResultSetImpl.java:
##########
@@ -254,73 +259,97 @@ public boolean booleanValue(int columnIndex) {
/** {@inheritDoc} */
@Override
public byte byteValue(String columnName) {
- return (byte) getValueNotNull(columnName);
+ Object number = getValueNotNull(columnName);
+
+ return TypeConversionUtils.castToByte(number);
}
/** {@inheritDoc} */
@Override
public byte byteValue(int columnIndex) {
- return (byte) getValueNotNull(columnIndex);
+ Number number = getValueNotNull(columnIndex);
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
