ptupitsyn commented on code in PR #7400:
URL: https://github.com/apache/ignite-3/pull/7400#discussion_r2704123083
##########
modules/api/src/main/java/org/apache/ignite/table/TupleImpl.java:
##########
@@ -459,4 +464,122 @@ private <T> T valueNotNull(String columnName) {
return value;
}
+
+ /** Casts a {@link Number} to {@code byte}. */
+ private static byte castToByte(Object number) {
Review Comment:
Should we document the code duplication so we don't forget to update both
parts? Do we have tests to check that both implementations work the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
