ptupitsyn commented on code in PR #7400: URL: https://github.com/apache/ignite-3/pull/7400#discussion_r2694865407
########## modules/api/src/main/java/org/apache/ignite/lang/util/TypeConversionUtils.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.lang.util; + +/** + * Utility methods for converting {@link Number} instances to Java primitive numeric types. + * + * <p>The following conversions are supported: + * <ul> + * <li>Any integer type to any other integer type with range checks (e.g. {@link Long} to {@link Byte} + * may throw {@link ArithmeticException} if the value doesn't fit into {@link Byte} range).</li> + * <li>{@link Float} to {@link Double} are always allowed.</li> + * <li>{@link Double} to {@link Float} with precision checks. Throws {@link ArithmeticException} + * if the value cannot be represented as FLOAT without precision loss.</li> + * </ul> + */ +public class TypeConversionUtils { Review Comment: ```suggestion class TypeConversionUtils { ``` Let's avoid public API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
