tmgodinho commented on code in PR #7730:
URL: https://github.com/apache/ignite-3/pull/7730#discussion_r2904776819
##########
modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java:
##########
@@ -373,6 +373,18 @@ public <T> CompletableFuture<AsyncResultSet<T>>
executeAsyncInternal(
false
).handle((BiFunction<AsyncResultSet<T>, Throwable,
CompletableFuture<AsyncResultSet<T>>>) (r, err) -> {
if (err != null) {
+ if (ctx.firstReqFut != null) {
+ // Create failed transaction.
+ // TODO: Check what is the id here.
+ long id = -1;
+ ClientTransaction failed = new
ClientTransaction(ctx.channel, ch, id, ctx.readOnly, null,
+ ctx.pm, null, ch.observableTimestamp(), 0);
+ failed.fail();
+ ctx.firstReqFut.complete(failed);
+ // Txn was not started, rollback is not required.
+ return failedFuture(err);
Review Comment:
Could you check what the appropriate ID is for the transaction in this case?
I could not reason about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
