ptupitsyn commented on code in PR #7730:
URL: https://github.com/apache/ignite-3/pull/7730#discussion_r2959195957
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -1183,6 +1193,16 @@ private void processOperationInternal(
metrics.requestsProcessedIncrement();
+ // We may decide to merge ResponseWriterExt with
ResponseWriter (as a default method.)
+ if (res instanceof ResponseWriterExt) {
+ try {
Review Comment:
We are already inside a try-catch block, I would remove this one.
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -1183,6 +1193,16 @@ private void processOperationInternal(
metrics.requestsProcessedIncrement();
+ // We may decide to merge ResponseWriterExt with
ResponseWriter (as a default method.)
Review Comment:
Maybe even remove the new interface and use something like `AutoCloseable`
for this purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
