valepakh commented on code in PR #7914:
URL: https://github.com/apache/ignite-3/pull/7914#discussion_r3032529522
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageImplGenerator.java:
##########
@@ -653,20 +651,11 @@ private static void
generateEqualsAndHashCode(TypeSpec.Builder messageImplBuilde
.addStatement("var otherMessage = ($T)other",
message.implClassName())
.addStatement(comparisonStatement.build());
- hashCode
- .addStatement("int result = 0");
+ first = true;
Review Comment:
This analysis in incorrect, there's a separate code path for zero getter
##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageImplGenerator.java:
##########
@@ -653,20 +651,11 @@ private static void
generateEqualsAndHashCode(TypeSpec.Builder messageImplBuilde
.addStatement("var otherMessage = ($T)other",
message.implClassName())
.addStatement(comparisonStatement.build());
- hashCode
- .addStatement("int result = 0");
+ first = true;
Review Comment:
This analysis in incorrect, there's a separate code path for zero getters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
