valepakh commented on PR #7914: URL: https://github.com/apache/ignite-3/pull/7914#issuecomment-4191517381
> Most changes in test are not on hot path. Does it make sense applying the rule to the tests? It doesn't, do you want me to revert all of the tests changes? > Most of objects are not persistent\serializable and their hash code is not transferred. So, there is no need to keep "compatibility". E.g. all touched SQL objects, Nullable, QualifiedName. It's true but I didn't want to go over each change and see if it needs to be kept the same or not, just made a bulk edit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
