valepakh commented on PR #7914: URL: https://github.com/apache/ignite-3/pull/7914#issuecomment-4192148918
> > It's true but I didn't want to go over each change and see if it needs to be kept the same or not, just made a bulk edit. > > "go over each change and see if it needs" this is what engineer should do - prove the change is reasonable, right? As a reviewer, I went through every change and tried to understand why it is done in the way is done. Bulk edit - saves your time, but not reviwers. In this case I think it's better to do in in bulk so that we don't need to make the same mistake again. What are you suggesting, to not merge this at all? Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
