ibessonov commented on code in PR #7917:
URL: https://github.com/apache/ignite-3/pull/7917#discussion_r3038485269
##########
modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/inmemory/ItBplusTreeFakeReuseVolatilePageMemoryTest.java:
##########
@@ -32,7 +32,7 @@ public class ItBplusTreeFakeReuseVolatilePageMemoryTest
extends ItBplusTreeVolat
protected ReuseList createReuseList(
int grpId,
int partId,
- PageMemory pageMem,
+ PartitionPageMemory pageMem,
Review Comment:
Thank you! Please let me clarify few points here:
- There's no danger here, it's not a functional bug, the issue doesn't block
anyone from the production usages. All it gives us is temporary performance
issues that go away shortly after a checkpoint is started.
- The problem cannot be fully fixed due to "stop the world" approach of a
checkpoint process. All we can do it to minimize the pause. The same issue
exists in Apache Ignite 2 in a more severe form, due to the way WAL works there.
- Page replacement issue, to my knowledge, does not exist in Apache Ignite 2
in this form, and I hope to address it in Apache Ignite 3 eventually as
described in the aforementioned Epic.
- There is no information about release, because there's no deadline to this
activity. It'll get released when it's finished, I can't say more.
@tkalkirill Are you planning to do a formal review of this PR, or was this
just a single comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
