alievmirza commented on code in PR #7917:
URL: https://github.com/apache/ignite-3/pull/7917#discussion_r3044018889
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/datastructure/DataStructure.java:
##########
@@ -32,6 +32,7 @@
import org.apache.ignite.internal.pagememory.FullPageId;
import org.apache.ignite.internal.pagememory.PageIdAllocator;
import org.apache.ignite.internal.pagememory.PageMemory;
Review Comment:
do we need this Import?
##########
modules/page-memory/src/testFixtures/java/org/apache/ignite/internal/pagememory/benchmark/PersistentPageMemoryBenchmarkBase.java:
##########
@@ -71,6 +75,10 @@ protected PersistentPageMemory persistentPageMemory() {
return persistentPageMemory;
}
+ protected PartitionPageMemory partitionPageMemory(int partitionId) {
+ return partitionPageMemoryMap.get(new GroupPartitionId(GROUP_ID,
partitionId));
Review Comment:
redundant space. I wonder why our checks couldn't report this
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/datastructure/DataStructure.java:
##########
Review Comment:
Shouldn't be `PartitionPageMemory`?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/PageMemory.java:
##########
@@ -39,35 +37,19 @@ public interface PageMemory extends PageIdAllocator,
PageSupport {
*/
int pageSize();
- /**
- * Returns a page size without the encryption overhead, in bytes.
- *
- * @param groupId Group id.
- */
- // TODO IGNITE-16350 Consider renaming.
- int realPageSize(int groupId);
-
/**
* Returns a page's size with system overhead, in bytes.
*/
// TODO IGNITE-16350 Consider renaming.
int systemPageSize();
- /**
- * Wraps a page address, obtained by a {@code readLock}/{@code writeLock}
or their variants, into a direct byte buffer.
- *
- * @param pageAddr Page address.
- * @return Page byte buffer.
- */
- ByteBuffer pageBuffer(long pageAddr);
-
/**
* Returns the total number of pages loaded into memory.
*/
long loadedPages();
/**
- * Returns a registry to obtain {@link PageIo} instances for pages.
+ * Creates a new instance of {@link PartitionPageMemory} for a specified
partition.
*/
- PageIoRegistry ioRegistry();
+ PartitionPageMemory createPartitionPageMemory(int groupId, int
partitionId);
Review Comment:
missing javadoc params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
