tkalkirill commented on code in PR #7917:
URL: https://github.com/apache/ignite-3/pull/7917#discussion_r3063787514
##########
modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/inmemory/ItBplusTreeFakeReuseVolatilePageMemoryTest.java:
##########
@@ -32,7 +32,7 @@ public class ItBplusTreeFakeReuseVolatilePageMemoryTest
extends ItBplusTreeVolat
protected ReuseList createReuseList(
int grpId,
int partId,
- PageMemory pageMem,
+ PartitionPageMemory pageMem,
Review Comment:
1. Overall, how much of a performance drop can this be? Could it cause a
query to take a few seconds instead of a few milliseconds?
2. By how much will pauses be minimized? In numbers, percentages or parrots?
PR about Ignite 3.0, I suggest not touching 2.0.
3. Great!
4. This is sad, I would like to see it in 3.2.
I'll try to do it within a couple of working days, if it doesn't happen by
Tuesday, consider it just a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
