AMashenkov commented on PR #7914: URL: https://github.com/apache/ignite-3/pull/7914#issuecomment-4192851589
> > Most changes in test are not on hot path. > > Does it make sense applying the rule to the tests? > > Most of objects are not persistent\serializable and their hash code is not transferred. > > So, there is no need to keep "compatibility". > > E.g. all touched SQL objects, Nullable, QualifiedName. > > No, we shouldn't make any difference between test and production code base. > > 1. It creates inconsistencies > 2. We should treat test code the same way we treat production > 3. Any performance gains are valid especially for test code 1, 2. Do you mean inconsistencies in styles? This is not about a style. I see performance vs readability here. Readability in tests is more important. 3. In tests I see classes which implements unused `hashcode` method. The author just generated it or followed the `equals` method contract, when implemented an `equals` method. Anyone measured performance? like we did here https://github.com/apache/ignite-3/pull/7932 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
