[ https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312001#comment-17312001 ]
Tian Jiang commented on IOTDB-1266: ----------------------------------- I see. This part is indeed weird. It requires `!hasLimit` but it still uses `result.size() == plan.getLimit()`. I guess `limit` is treated as a fetch size in this case but it really deserves another name. It can be fixed by using a separated fetch size instead of re-using `limit`. > SHOW TIMESERIES will only display 2000 timeseries > ------------------------------------------------- > > Key: IOTDB-1266 > URL: https://issues.apache.org/jira/browse/IOTDB-1266 > Project: Apache IoTDB > Issue Type: Improvement > Components: Cluster > Reporter: Yifu Zhou > Assignee: Yifu Zhou > Priority: Major > Fix For: 0.12.0 > > > The BUG is in the applyShowTimeseriesLimitOffset method. If there are 10000 > timeseries data, when first time go in this method, and the default limit is > 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. > For the reason that 10000 > 1000(limit+offset), so it will do the second > iteration. And now offset is set to 1000. Once the offset != 0, it will do > plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after > return 1000 timeseries from showTimeSeriesResults, it will end. > In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... > If the default limit is 1000, it means that if we have 10000 timeseries, we > have to do 10 times iterations, and each iteration we need to fetch the > timeseries data from all the servers. > I think there are two ways, one is to keep this > applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am > confused what why we have to set it 0), the other is remove > applyShowTimeseriesLimitOffset because I think it is useless... > Any idea here? -- This message was sent by Atlassian Jira (v8.3.4#803005)