[ https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315202#comment-17315202 ]
Yifu Zhou commented on IOTDB-1266: ---------------------------------- Thanks Tian, There is still some problems. If we commend SHOW TIMESERIES and want to fetch all the timesieses data, right now, in my modified solution, the fetch size will be Integer.MAX_VALUE for each node. I think It is too much pressure for the memory. Another solution is to use hasNextWithoutConstraint() method and fetch the data 1000 by 1000. (I think this is your previous idea to avoid fetch size). But here has another problem: when we commend SHOW TIMESERIES and want to fetch all the timesieses data, I set the limit 1000 and want to fetch thousand by thousand, if we have 3 nodes, so for the first iteration I will fetch 3,000 ts totally and display them, the second iteration will fetch another 3,000 ts and so on. But now the data displayed is not in sequence. So the offset and limit may be useless... Any idea here? Thanks! > SHOW TIMESERIES will only display 2000 timeseries > ------------------------------------------------- > > Key: IOTDB-1266 > URL: https://issues.apache.org/jira/browse/IOTDB-1266 > Project: Apache IoTDB > Issue Type: Improvement > Components: Cluster > Reporter: Yifu Zhou > Assignee: Yifu Zhou > Priority: Major > Labels: pull-request-available > Fix For: 0.12.0 > > > The BUG is in the applyShowTimeseriesLimitOffset method. If there are 10000 > timeseries data, when first time go in this method, and the default limit is > 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. > For the reason that 10000 > 1000(limit+offset), so it will do the second > iteration. And now offset is set to 1000. Once the offset != 0, it will do > plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after > return 1000 timeseries from showTimeSeriesResults, it will end. > In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... > If the default limit is 1000, it means that if we have 10000 timeseries, we > have to do 10 times iterations, and each iteration we need to fetch the > timeseries data from all the servers. > I think there are two ways, one is to keep this > applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am > confused what why we have to set it 0), the other is remove > applyShowTimeseriesLimitOffset because I think it is useless... > Any idea here? -- This message was sent by Atlassian Jira (v8.3.4#803005)