[
https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315204#comment-17315204
]
Tian Jiang commented on IOTDB-1266:
-----------------------------------
A thorough solution is to fully refactor the ShowDataset and use an iterative
model like other datasets:
1. Create an iterator of timeseries for each data group;
2. Each iterator pulls a batch from its data group;
3. The coordinator merges the batches to generate an ordered batch and returns;
4. Repeat 2. and 3. until the results are exhausted.
> SHOW TIMESERIES will only display 2000 timeseries
> -------------------------------------------------
>
> Key: IOTDB-1266
> URL: https://issues.apache.org/jira/browse/IOTDB-1266
> Project: Apache IoTDB
> Issue Type: Improvement
> Components: Cluster
> Reporter: Yifu Zhou
> Assignee: Yifu Zhou
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.12.0
>
>
> The BUG is in the applyShowTimeseriesLimitOffset method. If there are 10000
> timeseries data, when first time go in this method, and the default limit is
> 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries.
> For the reason that 10000 > 1000(limit+offset), so it will do the second
> iteration. And now offset is set to 1000. Once the offset != 0, it will do
> plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after
> return 1000 timeseries from showTimeSeriesResults, it will end.
> In my opinion, it is useless for the applyShowTimeseriesLimitOffset method...
> If the default limit is 1000, it means that if we have 10000 timeseries, we
> have to do 10 times iterations, and each iteration we need to fetch the
> timeseries data from all the servers.
> I think there are two ways, one is to keep this
> applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am
> confused what why we have to set it 0), the other is remove
> applyShowTimeseriesLimitOffset because I think it is useless...
> Any idea here?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
