chibenwa commented on code in PR #3198:
URL: https://github.com/apache/james-project/pull/3198#discussion_r4119319993
##########
protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java:
##########
@@ -184,9 +260,16 @@ public boolean isHandling(Event event) {
@Override
public Publisher<Void> reactiveEvent(Event event) {
- return Mono.fromRunnable(Throwing.runnable(countDownLatch::await))
- .then(Mono.defer(() -> unsolicitedResponses(session,
responder, false)))
- .then(Mono.fromRunnable(responder::flush));
+ return idleReadySink.asMono()
+ .then(Mono.defer(() -> {
+ if (!idleActive.get()) {
+ return Mono.empty();
+ }
+ return unsolicitedResponses(session, responder, false)
+ .then(Mono.fromRunnable(responder::flush));
+ }))
+ .onErrorResume(e -> logAsMono(() -> LOGGER.debug("Failed to
push updates to idling client", e)))
Review Comment:
```suggestion
.onErrorResume(e -> logAsMono(() -> LOGGER.info("Failed to
push updates to idling client", e)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
