prosgarz35 commented on PR #3198: URL: https://github.com/apache/james-project/pull/3198#issuecomment-5902569509
Thanks for the thorough review, Benoit! 🙏 Both remarks addressed: Confirmed — moved off CountDownLatch entirely in favor of the reactive Sinks.One<Void> handshake + session.threadSafe(responder). Good catch on the cleanupIdle() shortcut — you're right, the client only cares that IDLE is no longer registered, not who did the cleanup. Applied your suggested change: cleanupIdle(...) is now called unconditionally, so DONE always gets an OK regardless of a concurrent cleanup race. Really appreciate you taking the time to go through this one line by line. <3 i really thanks for you hard work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
