pan3793 commented on code in PR #6305:
URL: https://github.com/apache/kyuubi/pull/6305#discussion_r1563877195
##########
build/dist:
##########
@@ -248,7 +248,18 @@ echo -e "\nBuilding with..."
# shellcheck disable=SC2145
echo -e "\$ ${BUILD_COMMAND[@]}\n"
+# shellcheck disable=SC2050
+if [ "$SCALA_VERSION" = "2.12" ]; then
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.13 -pl
:kyuubi-spark-sql-engine_2.13 )
Review Comment:
`-am` is required, otherwise the mvn command should fail if you don't have
.m2 cache
nit: one space between words. EXTRA_BUILD_COMMAND =>
EXTRA_SPARK_ENGINE_BUILD_COMMAND. `else` is required to safety
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
