pan3793 commented on code in PR #6305:
URL: https://github.com/apache/kyuubi/pull/6305#discussion_r1563878590
##########
build/dist:
##########
@@ -296,7 +307,9 @@ done
cp
"$KYUUBI_HOME/externals/kyuubi-flink-sql-engine/target/kyuubi-flink-sql-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/flink/"
# Copy spark engines
-cp
"$KYUUBI_HOME/externals/kyuubi-spark-sql-engine/target/kyuubi-spark-sql-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/spark/"
+for SUPPORT_VERSION in 2.12 2.13; do
Review Comment:
SUPPORT_VERSION is not a good var name here, as SCALA_VERSION is occupied,
use `i` or `scala_version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
