yikf commented on code in PR #6305:
URL: https://github.com/apache/kyuubi/pull/6305#discussion_r1563906413
##########
build/dist:
##########
@@ -248,7 +248,18 @@ echo -e "\nBuilding with..."
# shellcheck disable=SC2145
echo -e "\$ ${BUILD_COMMAND[@]}\n"
+# shellcheck disable=SC2050
+if [ "$SCALA_VERSION" = "2.12" ]; then
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.13 -pl
:kyuubi-spark-sql-engine_2.13 )
+else
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.12 -pl
:kyuubi-spark-sql-engine_2.12 )
Review Comment:
Thanks @PorterZhang2021 contribution, there are some minor comments:
- Apache kyuubi does not have a profile of the scala-2.12, you can use the
default profile for scala-2.12;
- `$@` is actually unnecessary;
You can also [create a kyuubi
tarball](https://kyuubi.readthedocs.io/en/master/contributing/code/distribution.html),
and use it to manual E2E test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
