pan3793 commented on code in PR #6305:
URL: https://github.com/apache/kyuubi/pull/6305#discussion_r1565130441
##########
build/dist:
##########
@@ -248,7 +248,18 @@ echo -e "\nBuilding with..."
# shellcheck disable=SC2145
echo -e "\$ ${BUILD_COMMAND[@]}\n"
+# shellcheck disable=SC2050
+if [ "$SCALA_VERSION" = "2.12" ]; then
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.13 -pl
:kyuubi-spark-sql-engine_2.13 )
+else
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.12 -pl
:kyuubi-spark-sql-engine_2.12 )
Review Comment:
> kyuubi doesn't seem to have a profile for scala-2.12?
yes, one more thing we need to verify, if both `scala-2.12` and `scala-2.13`
exist, which one will take effect if both profiles are activated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
