yikf commented on code in PR #6305:
URL: https://github.com/apache/kyuubi/pull/6305#discussion_r1565124971
##########
build/dist:
##########
@@ -248,7 +248,18 @@ echo -e "\nBuilding with..."
# shellcheck disable=SC2145
echo -e "\$ ${BUILD_COMMAND[@]}\n"
+# shellcheck disable=SC2050
+if [ "$SCALA_VERSION" = "2.12" ]; then
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.13 -pl
:kyuubi-spark-sql-engine_2.13 )
+else
+ EXTRA_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.12 -pl
:kyuubi-spark-sql-engine_2.12 )
Review Comment:
yea, but in the case of actually compiling only the spark engine jar, the
additional parameters may not be necessary and may instead affect the
compilation of the current module;
For example, if the user create a kyuubi tarball compiled by `./dev/dist
-Pscala-2.13`, we need to compile the spark engine jar of `scala-2.12`. then
the compile command for this block becomes
```shell
"$MVN" install $MVN_DIST_OPT **-Pscala-2.13** ~~-Pscala-2.12~~ -pl:
Kyuubi-spark-SQl-engine_2.2.12 -am?
```
BTW, kyuubi doesn't seem to have a profile for scala-2.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
