pan3793 commented on code in PR #7300:
URL: https://github.com/apache/kyuubi/pull/7300#discussion_r2772305660
##########
python/pyhive/hive.py:
##########
@@ -236,6 +240,8 @@ def __init__(
if auth is None:
auth = 'NONE'
socket = thrift.transport.TSocket.TSocket(host, port)
+ if connection_timeout:
+ socket.setTimeout(connection_timeout)
Review Comment:
> user could choose to do this already by passing a thrift transport object.
the user passed `thrift_transport` should already be established? if so, the
user takes responsibility to set `connectTimeout`.
I think what we should do here is
1. add two args `connect_timeout` and `socket_timeout`
2. for `thrift_transport`, suppose it is already established, just set
`socket_timeout`
3. for host/port case, use `connect_timeout` for the connecting phase, and
change it to `socket_timeout` after the connection is established
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
