ryanbordo commented on code in PR #7300:
URL: https://github.com/apache/kyuubi/pull/7300#discussion_r2820767449


##########
python/pyhive/hive.py:
##########
@@ -236,6 +240,8 @@ def __init__(
             if auth is None:
                 auth = 'NONE'
             socket = thrift.transport.TSocket.TSocket(host, port)
+            if connection_timeout:
+                socket.setTimeout(connection_timeout)

Review Comment:
   Pushed up a solution for this, don't love it but should work. We can't 
guarantee a public API for setting a socket timeout so I believe it's this or 
reverting to only setting a timeout once, for connection and socket. Let me 
know what you think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to