ryanbordo commented on code in PR #7300:
URL: https://github.com/apache/kyuubi/pull/7300#discussion_r2836752132


##########
python/pyhive/hive.py:
##########
@@ -236,6 +240,8 @@ def __init__(
             if auth is None:
                 auth = 'NONE'
             socket = thrift.transport.TSocket.TSocket(host, port)
+            if connection_timeout:
+                socket.setTimeout(connection_timeout)

Review Comment:
   Reverting to the previous PR for these reasons. Plus, the pyhive connection 
wrapper provides polling, which lessons the need for a separate socket timeout



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to