ulrichenslin commented on a change in pull request #260: [LOG4J2-2561] JEP223
version detection fix for JDK 9 and up
URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261837959
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##########
@@ -134,7 +134,13 @@ private static boolean isPreJava8() {
final String version = System.getProperty("java.version");
Review comment:
I agree, but wanted to make the code change as small as possible, since it
is a very minor change.
If we want to be more adventures, we should move the
org.apache.logging.log4j.util.Constants#getMajorVersion to core, and just have
everything call that. Then the version detection is centralised and can we can
test it as a public method.
How to you advise we move forward on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
