rgoers commented on a change in pull request #260: [LOG4J2-2561] JEP223 version
detection fix for JDK 9 and up
URL: https://github.com/apache/logging-log4j2/pull/260#discussion_r261841957
##########
File path:
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/AbstractStringLayout.java
##########
@@ -134,7 +134,13 @@ private static boolean isPreJava8() {
final String version = System.getProperty("java.version");
Review comment:
Personally, I dislike checking for versions. I much prefer checking for
features. But seeing that this was already implemented I wouldn't expect you to
change that.
I am a bit confused by your question though. It looks like Constants has a
getMajorVersion method that has the same problem. I would recommend you just
fix that and then have AbstractStringLayout reference
Constants.JAVA_MAJOR_VERSION
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
