[ 
https://issues.apache.org/jira/browse/LOG4J2-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488065#comment-17488065
 ] 

Piotr P. Karwasz edited comment on LOG4J2-2975 at 2/7/22, 12:37 PM:
--------------------------------------------------------------------

[~rgoers] : on which JVMs do you expect a `ClassNotFoundException`? I tested 
the addition of `makeLoggingEventBuilder` on HotSpot (Java 1.8) and the class 
loaded correctly under SLF4J 1.8.

To be extra careful, one might add a class extending `Log4jLogger` that will 
override `makeLoggingEventBuilder` and will be used only if SLF4J 2.0 is 
detected.


was (Author: JIRAUSER280472):
[~rgoers] : on which JVMs do you expect `ClassNotFoundException`? I tested the 
addition of `makeLoggingEventBuilder` on HotSpot and the class loaded correctly 
under SLF4J 1.8.

> SLF4J fluent API fails to capture call site location due to missing 
> LoggingEventAware implementation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-2975
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2975
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: SLF4J Bridge
>    Affects Versions: 2.13.3
>            Reporter: Daniel Gray
>            Assignee: Ralph Goers
>            Priority: Major
>
> The logger outputs the wrong log line (120 for INFO, 117 for DEBUG, etc.) 
> instead of the line in the program that generated the log, when running with 
> the slf4j bridge. *This causes potential confusion when a person debugging 
> something is reading the logs as the line numbers are wrong!*
> I have prepared 2 simple CLI apps to show the correct behavior (with only 
> Log4J) and the incorrect behavior (with the SLF4J bridge). Both are using the 
> exact same configuration (log4j2.properties). The repositories of these 
> sample projects are:
> Good behavior with a pure log4j:
>  [https://github.com/danielthegray/log4j-nobugsample]
>  Wrong behavior with the slf4j bridge:
>  [https://github.com/danielthegray/slf4j-bugsample]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to