garydgregory commented on a change in pull request #794:
URL: https://github.com/apache/logging-log4j2/pull/794#discussion_r826947124
##########
File path:
log4j-1.2-api/src/test/java/org/apache/log4j/config/AbstractLog4j1ConfigurationTest.java
##########
@@ -276,7 +276,7 @@ private void testDailyRollingFileAppender(final String
configResource, final Str
public void testConsoleEnhancedPatternLayout() throws Exception {
final PatternLayout layout = (PatternLayout)
testConsole("config-1.2/log4j-console-EnhancedPatternLayout");
- assertEquals("%d{ISO8601} [%t][%c] %-5p %properties %ndc: %m%n",
layout.getConversionPattern());
+ assertEquals("%d{ISO8601} [%t][%c] %-5v1Level %properties %ndc: %m%n",
layout.getConversionPattern());
Review comment:
I think we need a comment before this line and one like it because I am
guessing that "v1Level" was converted by us when users say "level" in their 1.2
configuration files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
