ppkarwasz commented on PR #1534: URL: https://github.com/apache/logging-log4j2/pull/1534#issuecomment-1619060040
Thanks @oshai, The fix looks good to me. Can you also: - provide a test to validate your change (e.g. add a test case to [`CallerInformationTest`](https://github.com/apache/logging-log4j2/blob/2.x/log4j-slf4j2-impl/src/test/java/org/apache/logging/slf4j/CallerInformationTest.java)), - add a changelog file to `src/changelog/.2.x.x` (check the other entries for the format). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
