vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1532298634
##########
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##########
@@ -240,14 +240,6 @@ static void formatMessage(
return;
}
- // Fail if there are insufficient arguments
- if (analysis.placeholderCount > args.length) {
- final String message = String.format(
- "found %d argument placeholders, but provided %d for
pattern `%s`",
- analysis.placeholderCount, args.length, pattern);
- throw new IllegalArgumentException(message);
- }
Review Comment:
Agreed with @ppkarwasz's remark. Please provide sufficient test coverage for
all possibilities he shared. In particular, test not just the unhappy flow, but
also happy flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
