vy commented on code in PR #2393:
URL: https://github.com/apache/logging-log4j2/pull/2393#discussion_r1533763183
##########
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##########
@@ -68,15 +67,12 @@ void test_pattern_analysis(
}
}
- @ParameterizedTest
- @CsvSource({"1,foo {}", "2,bar {}{}"})
- void format_should_fail_on_insufficient_args(final int placeholderCount,
final String pattern) {
- final int argCount = placeholderCount - 1;
- assertThatThrownBy(() -> ParameterFormatter.format(pattern, new
Object[argCount], argCount))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage(
- "found %d argument placeholders, but provided %d for
pattern `%s`",
- placeholderCount, argCount, pattern);
Review Comment:
No, this is not needed. This file was already testing logged `StatusLogger`
messages – scroll down, you will see the associated @SeasonPanPan deleted. They
need to simply revert those changes and adapt them accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
