ppkarwasz commented on code in PR #3467:
URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1960356099
##########
log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java:
##########
@@ -67,21 +67,23 @@ public MongoDb4Connection(
final ConnectionString connectionString,
final MongoClient mongoClient,
final MongoDatabase mongoDatabase,
+ final String collectionName,
Review Comment:
> So the first problem is that the maven-wrapper breaks when running it on
my machine using maven 3.9.9
>
> Specifically it complains about needing to update the
`distributionSha256Sum` which is impossible because 3.9.9. comes with a sha-512
sum.
Can you provide the exact wrapper error? For example you can run:
```shell
MVNW_VERBOSE=true ./mvnw validate -N
```
The fact that Apache Maven does not publish a SHA256 checksum to Maven
Central doesn't matter, because the value is hardcoded in the
`wrapper.properties` file and committed to the Git repo. Each time I bump the
version of Maven used by the wrapper, I verify the signature of the archive and
compute the SHA256 checksum locally.
BTW: our wrapper currently uses Maven 3.9.8, not 3.9.9. I should probably
upgrade that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
