jesmith17 commented on code in PR #3467:
URL: https://github.com/apache/logging-log4j2/pull/3467#discussion_r1962053301


##########
log4j-mongodb4/src/main/java/org/apache/logging/log4j/mongodb4/MongoDb4Connection.java:
##########
@@ -67,21 +67,23 @@ public MongoDb4Connection(
             final ConnectionString connectionString,
             final MongoClient mongoClient,
             final MongoDatabase mongoDatabase,
+            final String collectionName,

Review Comment:
   Trying the VERBOSE command above produced this
   
   ```
   joshsmith@Joshs-Macbook-Air-2024 log4j-temp % MVNW_VERBOSE=true ./mvnw 
validate -N
   Couldn't find MAVEN_HOME, downloading and installing it ...
   Downloading from: 
https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.8/apache-maven-3.9.8-bin.zip
   Downloading to: 
/var/folders/wm/96zyw_3x4cdbvycjl7btg8sc0000gn/T/tmp.4xLeCVRCI2/apache-maven-3.9.8-bin.zip
   Found curl ... using curl
     % Total    % Received % Xferd  Average Speed   Time    Time     Time  
Current
                                    Dload  Upload   Total   Spent    Left  Speed
   100 8979k  100 8979k    0     0  1584k      0  0:00:05  0:00:05 --:--:-- 
1402k
   Error: Failed to validate Maven distribution SHA-256, your Maven 
distribution might be compromised.
   If you updated your Maven version, you need to update the specified 
distributionSha256Sum property.
   joshsmith@Joshs-Macbook-Air-2024 log4j-temp %
   ```
   
   that's after doing a `git reset` to bring back the deleted 
maven-wrapper.properties file. 
   
   I suspect that this needs to be moved to an issue so we can separate the 
resolution of this from the approval of the code changes for the appender. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to