ppkarwasz commented on PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3049959107
Hi @vy, > > So should we expose the class (and bump the version) or hide the class from the public API. I am slightly pending towards hiding the class. > > 1. Is this concern of yours addressed? (The API already exists and used widely. This class only makes it programmatically accessible.) That's a convincing argument. Making the enum public ensures that any future changes to the `%d` contract that would break existing behavior are flagged by BND as Java API-breaking—providing an additional safeguard. > 2. Shall we rename the class from `NamedDatePattern` to `NamedInstantPattern` in line with our recent wordsmithing efforts in _"instant formatting"_? That could be a sensible change. I don't have a strong preference either way, but aligning with our recent naming conventions might improve clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
