vy commented on code in PR #3839:
URL: https://github.com/apache/logging-log4j2/pull/3839#discussion_r2288091615
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java:
##########
@@ -617,4 +636,19 @@ private String[] parseConfigLocations(final String
configLocations) {
static List<ConfigurationFactory> getFactories() {
return factories;
}
+
+ /**
+ * Returns all configuration file extensions currently supported at
runtime.
+ * This aggregates extensions from all active configuration factories.
+ *
+ * @return list of supported file extensions
+ * @since 2.25.0
+ */
+ public static List<String> getActiveFileExtensions() {
Review Comment:
What is the use case for this? I have the impression the instance method
would just do fine.
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java:
##########
@@ -263,6 +264,14 @@ public static void removeConfigurationFactory(final
ConfigurationFactory factory
protected abstract String[] getSupportedTypes();
+ /**
+ * Returns the file extensions supported by this configuration factory.
+ *
+ * @return list of supported file extensions (e.g., ["xml", "json"])
+ * @since 2.25.0
+ */
+ public abstract List<String> getSupportedExtensions();
Review Comment:
1. Shall we use `Set<String>` instead?
2. Shall we rename this to `getSupportedFileExtensions` to emphasize the
_file_ aspect?
3. Version will probably need to be bumped to `2.26.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
