Copilot commented on code in PR #3913:
URL: https://github.com/apache/logging-log4j2/pull/3913#discussion_r2321510755
##########
log4j-parent/pom.xml:
##########
@@ -1140,6 +1140,52 @@
</executions>
</plugin>
+ <!--
+ ~ Drop the <build> section from flattened POMs.
+ ~ Keeps the consumer POM minimal and prevents flattened build-only
properties
+ ~ (e.g., `error-prone.version`) from causing resolution problems to
users.
+ ~
+ ~ Ref: https://github.com/apache/logging-log4j2/issues/3779
+ -->
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>flatten-maven-plugin</artifactId>
+ <executions>
+ <!-- First use the special `resolveCiFriendliesOnly` mode to replace
the special `${revision}` property with the actual version.
+ This is necessary because `flatten` mode does not support
`ci-friendly` versions. -->
+ <execution>
+ <id>flatten-revision</id>
Review Comment:
The `flatten-revision` execution is referenced in the comment but lacks any
configuration. This execution will not perform any action without goals, phase,
or configuration specified.
```suggestion
<id>flatten-revision</id>
<goals>
<goal>flatten</goal>
</goals>
<phase>initialize</phase>
<configuration>
<flattenMode>resolveCiFriendliesOnly</flattenMode>
</configuration>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
