vy commented on code in PR #3913:
URL: https://github.com/apache/logging-log4j2/pull/3913#discussion_r2327329484
##########
log4j-mongodb/pom.xml:
##########
@@ -128,13 +128,6 @@
<configuration>
<skip>true</skip>
</configuration>
- <dependencies>
Review Comment:
Is this change related? If not, I'd keep it aside.
##########
pom.xml:
##########
@@ -630,6 +630,37 @@
</configuration>
</plugin>
+ <!--
+ ~ Memento rules to remove overrides from child modules, whenever the
changes are moved to `logging-parent`.
+ ~
+ ~ When empty, please comment this execution out, but do not delete it!
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>remove-overrides</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <!-- Wait until we retrieve `parent.version` property in
`build-helper-maven-plugin` below -->
+ <phase>initialize</phase>
+ <inherited>false</inherited>
+ <configuration>
+ <rules>
+ <requireProperty>
+ <property>parent.version</property>
+ <regex>12\.1\.1</regex>
+ <regexMessage>Remember to remove overrides from child
modules, whenever the changes are moved to `logging-parent`:
+ * Remove the override `flatten-maven-plugin` configuration
from `log4j-parent/pom.xml`.</regexMessage>
Review Comment:
Why do we do this? Are we intending to move this _"non-BOM flattening"_
logic to `logging-parent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
