JongminChung commented on code in PR #4033:
URL: https://github.com/apache/logging-log4j2/pull/4033#discussion_r2825647947
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java:
##########
@@ -79,6 +79,21 @@ public String toString() {
}
}
+ private static final class CustomException extends Exception {
Review Comment:
Thanks for the review, @vy! I've applied all your suggestions:
1. Renamed to ToStringOverridingException
2. Changed constructor to use super(EXCEPTION) with no arguments
3. Added ToStringOverridingException.INSTANCE static field (following
TestFriendlyException.INSTANCE pattern)
4. toString() now returns a constant ("foo")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
