vy commented on code in PR #4033:
URL: https://github.com/apache/logging-log4j2/pull/4033#discussion_r2867854470
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java:
##########
@@ -545,9 +572,13 @@ private static List<Exception>
createExceptionsOfDifferentDepths() {
}
static String convert(final String pattern) {
+ return convert(pattern, EXCEPTION);
+ }
+
+ static String convert(final String pattern, final Throwable throwable) {
Review Comment:
It should be, since the new method is only used by this class:
```
$ cat p/A.java
package p;
public class A {
public static void main(String[] args) { System.out.println(f(1,2)); }
static int f(int i) { return i; }
private static int f(int i, int j) { return i + j; }
}
$ cat p/B.java
package p;
import static p.A.f;
public class B {
public static void main(String[] args) { System.out.println(f(1)); }
}
$ javac p/*.java
$ java p.A
3
$ java p.B
1
```
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
