JongminChung commented on code in PR #4033:
URL: https://github.com/apache/logging-log4j2/pull/4033#discussion_r2825111287
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/ThrowablePatternConverterTest.java:
##########
@@ -545,9 +572,13 @@ private static List<Exception>
createExceptionsOfDifferentDepths() {
}
static String convert(final String pattern) {
+ return convert(pattern, EXCEPTION);
+ }
+
+ static String convert(final String pattern, final Throwable throwable) {
Review Comment:
This can't be private since it's accessed from other classes within the same
package.
([Link](https://github.com/apache/logging-log4j2/blob/2.x/log4j-core-test/src/test/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverterTest.java#L22))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
