ramanathan1504 commented on code in PR #4199:
URL: https://github.com/apache/logging-log4j2/pull/4199#discussion_r3694649603
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java:
##########
@@ -616,12 +628,6 @@ private Configuration getConfiguration(
final ConfigurationSource source =
ConfigurationSource.fromResource(configName, loader);
if (source != null) {
- if (!factory.isActive()) {
Review Comment:
"Found configuration file {} for the inactive {} ... might be inactive due
to a missing dependency" ERROR from ConfigurationFactory. That line is commit
5d47e931aa by @vy, which raised it from WARN to ERROR and added the
missing-dependency wording. It only became unreachable because inactive
factories are now skipped at the top
of the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
