DragonFSKY commented on code in PR #4199:
URL: https://github.com/apache/logging-log4j2/pull/4199#discussion_r3694883806
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFactory.java:
##########
@@ -616,12 +628,6 @@ private Configuration getConfiguration(
final ConfigurationSource source =
ConfigurationSource.fromResource(configName, loader);
if (source != null) {
- if (!factory.isActive()) {
Review Comment:
While reviewing the changes again, I noticed that my latest approach weakens
the contract requested in #3896: an inactive factory is expected to reject
`getSupportedTypes()`. The existing file-specific diagnostic can only be
produced after querying the factory’s supported suffixes and finding a matching
resource. Logging before the early `continue` would instead produce a
factory-level message even when no matching configuration file exists. I have
restored the strict inactive behavior for now. Could you please confirm whether
this is the intended trade-off, or whether you would prefer another way to
retain the file-specific diagnostic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
