ramanathan1504 commented on code in PR #4199: URL: https://github.com/apache/logging-log4j2/pull/4199#discussion_r3861424116
########## src/changelog/.2.x.x/fix_configuration_factory_activation.xml: ########## @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="changed"> + <issue id="3896" link="https://github.com/apache/logging-log4j2/issues/3896"/> Review Comment: ````suggestion <issue id="3896" link="https://github.com/apache/logging-log4j2/issues/3896"/> <issue id="4199" link="https://github.com/apache/logging-log4j2/pull/4199"/> ```` ########## src/changelog/.2.x.x/fix_configuration_factory_activation.xml: ########## @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xmlns="https://logging.apache.org/xml/ns"; + xsi:schemaLocation="https://logging.apache.org/xml/ns https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="changed"> + <issue id="3896" link="https://github.com/apache/logging-log4j2/issues/3896"/> + <description format="asciidoc"> + Make `ConfigurationFactory` implementations consistently report active state and decline configuration creation Review Comment: ````suggestion Skip inactive `ConfigurationFactory` implementations, while still reporting matching configuration files. ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
